test: move packages to workspace vitest #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
frolic
changed the title
frolic
changed the title
because vitest global setup starts anvil at a specific port
This reverts commit 61d08ac.
frolic
changed the title
frolic
force-pushed
the
holic/workspace-vitest
branch
from
93a643d to
9bd27a9
Compare
alvrs
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although #3526 fixes one instance of running tests from workspace root or in a package, it breaks down once we add more packages and parallelism. The source of this issue steps from the fact that the thing running Vitest (and thus starting up Anvil) is parallelized, rather than letting Vitest do the parallelizing.
To work around this, I made a
with-anvilCLI wrapper that 1) starts up Anvil before starting the inner command and 2) passes the Anvil URL to the inner command via env var.The downside is you have to remember to run
with-anvilif you want to run Anvil tests from outside the context of the workspace root. But I left a nice warning to guide you to the right thing, making it easy to copy+paste and move on:mud/test/with-anvil/src/getAnvilRpcUrl.ts
Lines 6 to 15 in 399afe0
Snapshots got updated because newer Vitest changed their snapshot formatting (mostly reduces escaping).
closes #2409